Add OG title and description to course about pages #2436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,6 +26,9 @@ | |||
| %> | |||
|
|
|||
| <%include file="${google_analytics_file}" /> | |||
|
|
|||
| <meta property="og:title" content="${get_course_about_section(course, 'title')}" /> | |||
There was a problem hiding this comment.
Please add a comment above these properties that explain these are open graph tags. May be worth additionally linking to https://developers.facebook.com/docs/opengraph/howtos/maximizing-distribution-media-content
|
👍 once this code is self-documenting. I'm worried about other developers, unaware of what the heck |
|
@sarina - updated with comment and link. |
caesar2164
added a commit
that referenced
this pull request
Feb 3, 2014
Add OG title and description to course about pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@singingwolfboy & @adampalay - super quick PR to add OG titles and descriptions to about pages so Facebook and other social media get good content for sharing posts.